wzz6423 commented on code in PR #66464:
URL: https://github.com/apache/doris/pull/66464#discussion_r3718468318
##########
.github/workflows/code-review-runner.yml:
##########
@@ -252,13 +256,9 @@ jobs:
auth_object="$candidate"
break
- done < <(printf '%s\n' \
- 'oss://doris-community-ci/codex/auth.json.1' \
- 'oss://doris-community-ci/codex/auth.json.2' \
- 'oss://doris-community-ci/codex/auth.json.3' \
- 'oss://doris-community-ci/codex/auth.json.4' \
- 'oss://doris-community-ci/codex/auth.json.5' \
- | shuf)
+ done < <(
+ awk '$0 ~
/^oss:\/\/doris-community-ci\/codex\/auth\.json\.[0-9]+$/ { print }'
"$auth_listing" | shuf
+ )
if [ -z "$auth_object" ]; then
retry_at="$(date -u -d "@$earliest_retry_after_epoch"
+%Y-%m-%dT%H:%M:%SZ)"
Review Comment:
Addressed in 6b99e074cf. The auth setup now handles `ossutil ls` failure
with an explicit auth-specific `failure_reason`, materializes the strictly
filtered numbered candidates, and fails early with a distinct reason when that
candidate file is empty. The existing quota-only branch is now reached only
after at least one numbered auth object was discovered. Validation passed: YAML
parsing (1/1), `bash -n` for every workflow run block (21/21), and discovery
fixtures covering list failure, empty filtered results, a valid numbered
object, and mixed valid/invalid objects (4/4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
