gavinchou opened a new pull request, #66478:
URL: https://github.com/apache/doris/pull/66478
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
The Nereids migration of `ADMIN SET FRONTEND CONFIG` retained the global
`ADMIN` privilege check but omitted the cloud-mode root-only restriction from
the legacy DDL executor. This PR restores that restriction: in cloud mode, an
ordinary admin is rejected and root remains allowed. Non-cloud behavior is
unchanged.
### Release note
Restrict `ADMIN SET FRONTEND CONFIG` to root in cloud mode.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
-
`AdminSetFrontendConfigCommandTest#testCloudAdminCannotSetFrontendConfig`
- FE build with `build.sh --fe`
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [ ] No.
- [x] Yes. In cloud mode, non-root admin users can no longer update FE
runtime configuration.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
