yiguolei commented on code in PR #66513:
URL: https://github.com/apache/doris/pull/66513#discussion_r3725443288
##########
be/src/core/allocator.cpp:
##########
@@ -395,30 +395,40 @@ void* Allocator<clear_memory_, mmap_populate, use_mmap,
MemoryAllocator,
/// BTW, it's not possible to change alignment while doing realloc.
return buf;
}
- memory_check(new_size);
Review Comment:
If realloc can not extend memory on same memory address, it will malloc
another memory using malloc and then memcpy.
In this case, maybe will OOM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
