Gabriel39 commented on PR #66547: URL: https://github.com/apache/doris/pull/66547#issuecomment-5203750374
Reviewed at b148688e6728dcbcea01b58fbb768a5d2a42289b against the latest branch-4.1. I did not find a blocking correctness issue. The three-way merge also preserves the recently merged fix that unsets parquet.variant.shreddingSchema before writing unshredded files. Non-blocking test coverage suggestions: - Add an end-to-end JNI regression for a nested shredded object path such as profile.city. Nested extraction is currently covered only by Java unit tests. - Add a JNI regression for an unsupported numeric or array path such as payload[tags][0], verifying that it correctly falls back to reading the full Variant. - Add feature-gate tests for Variant nested inside ARRAY, MAP, and STRUCT; the implementation checks these types recursively, while the current test covers only a top-level Variant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
