eldenmoon commented on code in PR #66204:
URL: https://github.com/apache/doris/pull/66204#discussion_r3733292090
##########
be/src/storage/segment/segment_writer.cpp:
##########
@@ -452,7 +493,10 @@ Status
SegmentWriter::append_block_with_partial_content(const Block* block, size
auto full_block = _tablet_schema->create_block();
size_t input_id = 0;
for (auto i : including_cids) {
- full_block.replace_by_position(i,
block->get_by_position(input_id++).column);
+ const auto& input_column = block->get_by_position(input_id++);
Review Comment:
后面会删除tablet_column 的v2标记， 这么改不用到处set， 不用污染存储层逻辑， 而且改动是等价的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
