github-actions[bot] commented on code in PR #66628:
URL: https://github.com/apache/doris/pull/66628#discussion_r3752019662
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -2800,13 +2800,13 @@ private Table resolveTable(ConnectorSession session,
IcebergTableHandle handle)
// re-validates the credential even on a scope hit).
IcebergCatalogOps ops = catalogOpsResolver.apply(session);
Table raw = IcebergStatementScope.sharedTable(session,
handle.getDbName(), handle.getTableName(), () -> {
- if (context == null) {
- return loadRawTable(ops, handle);
- }
try {
- return context.executeAuthenticated(() -> loadRawTable(ops,
handle));
+ return context == null
+ ? loadRawTable(ops, handle)
+ : context.executeAuthenticated(() -> loadRawTable(ops,
handle));
} catch (Exception e) {
- throw new RuntimeException("Failed to load table for scan,
error message is:" + e.getMessage(), e);
+ throw IcebergExceptionUtils.wrapTableLoadFailure(
Review Comment:
The new normalizer only covers `resolveTable`'s base-metadata load. Once a
readable metadata JSON returns a table, missing snapshot metadata still escapes
raw from equality-delete/property reads, ordinary/count/cache-fallback
`planFiles()`, streaming estimate and lazy iteration, and both system planners
(including `position_deletes`); `$files`/`$entries` can defer manifest-body
opening to `IcebergSysTableJniScanner`. These are the same
`NotFoundException`/nested `FileNotFoundException` causes normalized by the new
MVCC/SHOW readers, but the IOException-only catches and runtime rethrows bypass
this helper. The new scan test only injects `loadTableFailure`. Please apply
the table-scoped normalization at every eager and lazy manifest-read boundary
without translating a cache failure before its SDK fallback or unrelated
authentication/validation/payload errors, and cover readable table metadata
plus a missing manifest list/body in ordinary, streaming, and both system
execution locatio
ns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
