englefly opened a new pull request, #66632:
URL: https://github.com/apache/doris/pull/66632
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
[not-in rows] is estimated as [total rows] - [in rows] in
FilterEstimation#visitNot. [in rows] is usually over-estimated when the
in-options cover the whole ndv or the ndv statistics is inaccurate, which makes
[not-in rows] under-estimated to nearly 0 and misleads the join reorder / limit
pushdown. Following the starrocks implementation
(PredicateStatisticsCalculator#visitInPredicate), when the estimated in
selectivity reaches 1.0 (full coverage), fall back to the default not-in
coefficient 1 - DEFAULT_IN_COEFFICIENT instead of 0 to avoid too small
estimation.
### Release note
None
### Check List (For Author)
- Test: Unit test (FilterEstimationTest: added testNotInFullCoverage and
testNotInAlmostFullCoverage; all 63 tests in the class pass)
- Behavior changed: Yes (not-in row count estimation may increase when
in-options cover the whole ndv)
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
