github-actions[bot] commented on code in PR #66643:
URL: https://github.com/apache/doris/pull/66643#discussion_r3755277454
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1397,11 +1397,6 @@ private boolean addColumnInternal(OlapTable olapTable,
Column newColumn, ColumnP
throw new DdlException("Time type is not supported for olap
table");
}
- // hll must be used in agg_keys
- if (newColumn.getType().isHllType() && KeysType.AGG_KEYS !=
olapTable.getKeysType()) {
Review Comment:
[P1] Keep HLL fenced for row-binlog tables
This removes the only ADD-column gate for HLL on DUP/UNIQUE-MoW row-binlog
tables. The ALTER now succeeds, but
`RowBinlogSourceDataWriter::prepare_by_source_block` wraps every non-key value
in `ColumnNullable`; even with an all-zero null map,
`OlapColumnDataConvertorHLL::convert_to_olap` returns `NotSupported` whenever
the null-map pointer is present. That status propagates from the common
AFTER-image conversion, so the first subsequent INSERT/UPDATE fails (historical
values need not be enabled). Please retain an HLL row-binlog fence or add
nullable-HLL conversion support, and cover ALTER followed by a write in
`row_binlog_p0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
