yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3757408803


##########
be/src/storage/tablet/tablet_schema.h:
##########
@@ -605,10 +605,9 @@ class TabletSchema : public MetadataAdder<TabletSchema> {
     // If schema version is not set, it should be -1
     int32_t schema_version() const { return _schema_version; }
     void clear_columns();
-    Block create_block(
-            const std::vector<uint32_t>& return_columns,
-            const std::unordered_set<uint32_t>* 
tablet_columns_need_convert_null = nullptr) const;
-    Block create_block() const;
+    // Create Blocks with physical TabletSchema column types and ordinals.
+    Block create_storage_block(const std::vector<uint32_t>& column_ids) const;

Review Comment:
   这里面的column id 是指啥?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to