github-actions[bot] commented on code in PR #66669:
URL: https://github.com/apache/doris/pull/66669#discussion_r3759148557
##########
be/test/cloud/cloud_schema_change_job_test.cpp:
##########
@@ -162,6 +245,18 @@ TEST_F(CloudSchemaChangeJobTest,
FillVersionHolesBeforeNewTabletRunning) {
resp->set_alter_version(2);
});
+ sp->set_call_back("CloudMetaMgr::prepare_rowset", [](auto&& outcome) {
Review Comment:
The new callbacks are never observed, so this test still passes if
historical capture/conversion is accidentally skipped: the final hole fill runs
while the tablet is `TABLET_NOTREADY` and deliberately skips missing versions
`<= alter_version` (so `[2,2]` stays absent), but it still creates the asserted
`[3,3]` hole before `[4,4]` and then marks the tablet RUNNING. Please assert
that prepare/commit was reached and that `[2,2]` exists as a non-hole converted
rowset (or otherwise verify full `[0,4]` continuity), so the fixture repair
actually protects the dependency it adds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
