yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3764125365
##########
be/src/storage/tablet/tablet_reader.cpp:
##########
@@ -463,25 +357,18 @@ Status TabletReader::_init_orderby_keys_param(const
ReaderParams& read_params) {
return Status::OK();
}
-Status TabletReader::_init_conditions_param(const ReaderParams& read_params) {
+Status TabletReader::_init_column_predicates(const ReaderParams& read_params) {
SCOPED_RAW_TIMER(&_stats.tablet_reader_init_conditions_param_timer_ns);
- std::vector<std::shared_ptr<ColumnPredicate>> predicates;
- std::copy(read_params.predicates.cbegin(), read_params.predicates.cend(),
- std::inserter(predicates, predicates.begin()));
- // Function filter push down to storage engine
- auto is_like_predicate = [](std::shared_ptr<ColumnPredicate> _pred) {
- return dynamic_cast<LikeColumnPredicate*>(_pred.get()) != nullptr;
- };
-
- for (const auto& filter : read_params.function_filters) {
- predicates.emplace_back(_parse_to_predicate(filter));
- auto pred = predicates.back();
-
- const auto& col = _tablet_schema->column(pred->column_id());
+ auto predicates = read_params.predicates;
+ for (const auto& predicate : predicates) {
+ if (predicate->type() != PredicateType::LIKE) {
Review Comment:
这里加注释，为什么like 需要特殊处理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
