hubgeter commented on code in PR #66620:
URL: https://github.com/apache/doris/pull/66620#discussion_r3764569387
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergMetadataOps.java:
##########
@@ -935,8 +965,14 @@ private void modifyTopLevelColumn(ExternalTable
dorisTable, ColumnPath columnPat
currentCol.type(), currentCol);
validateModifyColumnMetadata(column, resolvedPath.getFullPath(), true);
+ boolean variantModify = validateVariantTypeChange(
+ currentCol.type(), column.getType(),
resolvedPath.getFullPath());
+ validateVariantSchema(icebergTable, column.getType(),
columnPath.getFullPath(), false);
Review Comment:
Fixed in f89f87f4a9f: the Parquet write-capability gate now applies only
when introducing or converting a column to Variant. Metadata-only MODIFY of an
existing Variant column on an ORC table remains allowed, with unit coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
