github-actions[bot] commented on code in PR #66696: URL: https://github.com/apache/doris/pull/66696#discussion_r3766000853
########## .github/CODEOWNERS: ########## @@ -131,10 +134,13 @@ fe/fe-core/src/test/java/org/apache/doris/cloud/stage @liaoxin01 @gavinch fe/fe-core/src/test/java/org/apache/doris/cloud/storage @liaoxin01 @gavinchou fe/fe-core/src/test/java/org/apache/doris/cloud/system @deardeng @gavinchou fe/fe-core/src/test/java/org/apache/doris/cloud/transaction @liaoxin01 @gavinchou -fe/fe-core/src/test/java/org/apache/doris/fs @calvinkirs @morningman @gavinchou @Gabriel39 +fe/fe-core/src/test/java/org/apache/doris/connector @924060929 @CalvinKirs +fe/fe-core/src/test/java/org/apache/doris/datasource @924060929 @CalvinKirs +fe/fe-core/src/test/java/org/apache/doris/fs @CalvinKirs @924060929 @morningman @gavinchou @Gabriel39 fe/fe-core/src/test/java/org/apache/doris/journal @mymeiyi @gavinchou fe/fe-core/src/test/java/org/apache/doris/load @liaoxin01 @gavinchou -fe/fe-filesystem @calvinkirs @morningman @gavinchou +fe/fe-connector @924060929 @CalvinKirs Review Comment: **Preserve the existing connector POM owner.** GitHub uses only the last matching CODEOWNERS pattern, so this later module-wide rule overrides `**/pom.xml @CalvinKirs @morningman` for all 20 POMs under `fe/fe-connector`. After this change those build files are owned only by `@924060929 @CalvinKirs`, silently dropping `@morningman`, even though the generic POM rule was added for cross-cutting dependency compatibility, security, and license review. Please add a later POM-specific rule (for example, `fe/fe-connector/**/pom.xml @924060929 @CalvinKirs @morningman`) or otherwise retain that existing owner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
