github-actions[bot] commented on code in PR #66712:
URL: https://github.com/apache/doris/pull/66712#discussion_r3774833407
##########
build.sh:
##########
@@ -943,6 +944,7 @@ if [[ "${BUILD_BE}" -eq 1 ]]; then
-DSTRIP_DEBUG_INFO="${STRIP_DEBUG_INFO}" \
-DDISPLAY_BUILD_TIME="${DISPLAY_BUILD_TIME}" \
-DENABLE_PCH="${ENABLE_PCH}" \
+ -DENABLE_UNITY_BUILD="${ENABLE_UNITY_BUILD:-ON}" \
Review Comment:
[P2] Record unity mode in compile-benchmark metadata
This forwards a setting that changes the benchmark's TU population and
timing identities, but `compile_bench_init` persists
PCH/toolchain/generator/build type without the effective `ENABLE_UNITY_BUILD`,
so `summary.json` and the human report cannot say whether an archived run used
the generated pilot TUs or the original sources. The prior UT thread fixed
configure propagation; it does not make benchmark results self-describing.
Please persist and display the effective mode, and add an ON/OFF metadata
fixture.
##########
be/CMakeLists.txt:
##########
@@ -80,6 +80,20 @@ add_definitions(-DGLOG_CUSTOM_PREFIX_SUPPORT)
option(GLIBC_COMPATIBILITY "Enable compatibility with older glibc libraries."
ON)
option(USE_LIBCPP "Use libc++" OFF)
option(USE_JEMALLOC "Use jemalloc" ON)
+# Merge groups of .cpp files into jumbo translation units for much faster full
+# builds. Turn OFF for precise per-file diagnostics, per-file tooling
+# (clang-tidy/coverage), or the finest-grained incremental rebuilds.
+option(ENABLE_UNITY_BUILD "Enable CMake unity builds for BE targets" ON)
Review Comment:
[P2] Keep the natural-closure sweep source-isolated
The earlier `cut_impact.py` fix now refuses this unity database, but
`closure-sweep.sh` still runs `syntax_sweep.py --no-pch`, whose stated
guarantee is to check each source's natural include closure. That tool accepts
a generated unity file as one TU and compiles its ordered `.cpp` includes
together, so declarations, headers, or macros from an earlier member can make a
broken later member pass; baseline failures also collapse to a batch name.
Please make this sweep refuse unity with the existing OFF rebuild instruction
or replay every member independently, and add a masking-sibling fixture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
