gavinchou commented on code in PR #66348:
URL: https://github.com/apache/doris/pull/66348#discussion_r3780723455
##########
be/src/io/fs/azure_obj_storage_client.cpp:
##########
@@ -216,33 +229,40 @@ ObjectStorageResponse
AzureObjStorageClient::put_object(const ObjectStoragePathO
ObjectStorageUploadResponse AzureObjStorageClient::upload_part(const
ObjectStoragePathOptions& opts,
std::string_view stream,
int part_num) {
+ DCHECK(opts.upload_id.has_value());
auto client = _client->GetBlockBlobClient(opts.key);
+ std::string block_id = azure_multipart_block_id(*opts.upload_id, part_num);
auto resp = do_azure_client_call(
[&]() {
Azure::Core::IO::MemoryBodyStream memory_body(
reinterpret_cast<const uint8_t*>(stream.data()),
stream.size());
// The blockId must be base64 encoded
SCOPED_BVAR_LATENCY(s3_bvar::s3_multi_part_upload_latency);
- client.StageBlock(base64_encode_part_num(part_num),
memory_body);
+ client.StageBlock(block_id, memory_body);
},
opts, _tls_debug_context);
return ObjectStorageUploadResponse {
.resp = resp,
+ // Hive defers completion to FE, so the exact staged ID must cross
that boundary.
+ .etag = block_id,
Review Comment:
is it behavior change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
