This is an automated email from the ASF dual-hosted git repository.
hello-stephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c7a704658a6 [fix](cloud) Remove flaky idempotent injection debug test
(#66726)
c7a704658a6 is described below
commit c7a704658a6bcb3ff332cb2d9cdbdaee099db2b7
Author: Yixuan Wang <[email protected]>
AuthorDate: Fri Aug 14 11:31:03 2026 +0800
[fix](cloud) Remove flaky idempotent injection debug test (#66726)
Related PR: https://github.com/apache/doris/pull/56061
Problem Summary: ShortGetTabletStatsDebugStringTest enables the global
idempotent request injection configuration but does not restore it after
completion. Because meta_service_http_test.cpp and meta_service_test.cpp
are linked into the same test binary, later tests may create delayed
background bthreads.
Those tasks capture MetaServiceProxy through a raw this pointer and can
access impl_ after the proxy is destroyed, causing intermittent
heap-use-after-free, heap-buffer-overflow, or SEGV failures. Remove the
test to prevent this test-binary-wide configuration pollution and the
resulting flaky failures.
---
cloud/test/meta_service_http_test.cpp | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/cloud/test/meta_service_http_test.cpp
b/cloud/test/meta_service_http_test.cpp
index c043a99f5ef..3d311ade23b 100644
--- a/cloud/test/meta_service_http_test.cpp
+++ b/cloud/test/meta_service_http_test.cpp
@@ -3255,38 +3255,6 @@ TEST(MetaServiceHttpTest, VirtualClusterTest) {
} // namespace doris::cloud
}
-TEST(MetaServiceHttpTest, ShortGetTabletStatsDebugStringTest) {
- config::enable_idempotent_request_injection = true;
- auto sp = SyncPoint::get_instance();
- sp->enable_processing();
- DORIS_CLOUD_DEFER {
- sp->disable_processing();
- };
-
- HttpContext ctx(true);
- auto& meta_service = ctx.meta_service_;
- constexpr auto table_id = 10001, index_id = 11001, partition_id = 12001;
- int64_t tablet_id = 10001;
- GetTabletStatsRequest req;
- GetTabletStatsResponse res;
-
- brpc::Controller cntl;
- for (size_t i = 0; i < 50; i++) {
- auto* idx = req.add_tablet_idx();
- idx->set_table_id(table_id);
- idx->set_index_id(index_id);
- idx->set_partition_id(partition_id);
- idx->set_tablet_id(tablet_id + i);
- }
-
- meta_service->get_tablet_stats(&cntl, &req, &res, nullptr);
-
- sp->set_call_back("idempotent_injection_short_debug_string_for_get_stats",
[](auto&& args) {
- GetTabletStatsRequest debug_req =
*try_any_cast<GetTabletStatsRequest*>(args.back());
- ASSERT_EQ(10, debug_req.tablet_idx_size());
- });
-}
-
TEST(MetaServiceHttpTest, FixTabletIndexDbId) {
HttpContext ctx(true);
auto& meta_service = ctx.meta_service_;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
