hubgeter opened a new pull request, #66780:
URL: https://github.com/apache/doris/pull/66780
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The direct Parquet conversion path temporarily moves the
caller-owned column into the physical read column. If an interrupted read
returns before conversion, the caller is left with a null column pointer.
Complex-column cleanup can then dereference that null child and crash the BE.
Restore the transferred column on every early return, and disarm the
restoration only after conversion moves ownership back successfully. Add a
focused test that triggers the IO stop path and verifies the caller retains a
valid column.
coredump:
```
04:09:40
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_struct.h:98:23:
runtime error: member call on null pointer of type 'doris::IColumn'
04:09:40 *** Query id: 346501e80b2a4276-b032f92f6e9b6c3c ***
04:09:40 *** is nereids: 1 ***
04:09:40 *** tablet id: 0 ***
04:09:40 *** Aborted at 1786478874 (unix time) try "date -d @1786478874"
if you are using GNU date ***
04:09:40 *** Current BE git commitID: 206d71cd3c ***
04:09:40 *** SIGSEGV address not mapped to object (@0x0) received by PID
12549 (TID 37198 OR 0x7af300fc4640) from PID 0; stack trace: ***
04:09:40 0# doris::signal::(anonymous
namespace)::FailureSignalHandler(int, siginfo_t*, void*) at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/common/signal_handler.h:420
04:09:40 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone
.part.0] in /usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
04:09:40 2# JVM_handle_linux_signal in
/usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
04:09:40 3# 0x00007F007F83D520 in /lib/x86_64-linux-gnu/libc.so.6
04:09:40 4# doris::ColumnArray::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_array.h:141
04:09:40 5# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 6# doris::ColumnStruct::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_struct.h:98
04:09:40 7# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 8# doris::ColumnArray::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_array.h:141
04:09:40 9# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 10# doris::ColumnStruct::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_struct.h:98
04:09:40 11# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 12# doris::ColumnArray::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_array.h:141
04:09:40 13# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 14# doris::ColumnStruct::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_struct.h:98
04:09:40 15# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 16# doris::ColumnArray::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_array.h:141
04:09:40 17# doris::ColumnNullable::is_exclusive() const at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/column/column_nullable.h:268
04:09:40 18# doris::Block::clear_column_data(long) at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/core/block/block.cpp:816
04:09:40 19# doris::ParquetReader::get_next_block(doris::Block*, unsigned
long*, bool*) at
/mnt/disk3/pipeline/repo/selectdb-core_branch-selectdb-doris-4.1/selectdb-core/be/src/format/parquet/vparquet_reader.cpp:734
```
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
