gavinchou commented on code in PR #65658:
URL: https://github.com/apache/doris/pull/65658#discussion_r3792332270
##########
be/src/io/cache/block_file_cache_factory.h:
##########
@@ -100,6 +100,15 @@ class FileCacheFactory {
std::vector<std::string> get_base_paths();
+ /// Explicitly replace async-write service settings on every initialized
cache disk.
+ /// @param options Complete settings snapshot produced by the
configuration adapter.
+ /// @return OK after every service is updated; otherwise the first service
update error.
+ Status update_async_write_options(const AsyncCacheWriteServiceOptions&
options);
+
+ /// Start async-write workers for every initialized cache disk. Repeated
calls are idempotent.
+ /// @return OK after every service is ready; otherwise the first startup
error.
+ Status start_async_write_services();
Review Comment:
naming, it is actually not a `service` , in the context of doris,
BackendService(thrift rpc, brpc ...) is the `service`
better using something like `manager` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
