github-actions[bot] commented on code in PR #66794:
URL: https://github.com/apache/doris/pull/66794#discussion_r3793404014
##########
regression-test/suites/inverted_index_p0/test_single_column_multi_index1.groovy:
##########
@@ -161,11 +161,21 @@ suite("test_single_column_multi_index1", "p0") {
runMatchQueries()
sql """ DROP INDEX request_text_idx ON ${tableName}; """
- wait_for_latest_op_on_table_finish(tableName, timeout)
+ if (isCloudMode()) {
+ // Cloud uses a schema change job here; Local uses an asynchronous
index change job.
+ wait_for_latest_op_on_table_finish(tableName, timeout)
+ } else {
+ wait_for_build_index_on_partition_finish(tableName, timeout)
Review Comment:
The new local wait can still return successfully without the DROP job
finishing. `wait_for_build_index_on_partition_finish` only assigns `useTime =
t` while `t <= OpTimeout`, so a job that is still `WAITING_TXN`/`RUNNING` on
the last poll exits with `useTime == 60000` and the later `useTime <=
OpTimeout` assertion passes. A `CANCELLED` job behaves the same because the
helper counts only `FINISHED`; the fallback-enabled queries below can then pass
without proving physical cleanup. Please track an explicit success state, fail
immediately on `CANCELLED`, and assert completion (as
`test_index_change_6.groovy` does) before continuing at both new call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
