CalvinKirs opened a new pull request, #66817:
URL: https://github.com/apache/doris/pull/66817
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
`PLAN REPLAYER PLAY '<path>'` opened an arbitrary file path taken straight
from the SQL text, deserialized it into `OlapTable`/`View` objects and
installed them into the current `ConnectContext`, with no privilege check on
the command itself. It was only ever a developer aid and has no known users.
This removes the PLAY variant and everything that existed only for it:
- the `PLAY` lexer token (it was reserved and not in `nonReserved`, so
`play` becomes usable as a plain identifier)
- the `replayType` grammar rule; `replayCommand` is now `PLAN REPLAYER DUMP
query`
- `ReplayCommand.ReplayType` / `dumpFileFullPath` / `handleLoad`
- `MinidumpUtils.loadMinidumpInputs` / `compareJsonObjects` /
`compareJsonArrays`
- `Minidump.main`, the offline command-line entry that ran the same
load-replay-diff logic
`PLAN REPLAYER DUMP query` is unchanged.
### Release note
Remove the `PLAN REPLAYER PLAY` statement. `PLAN REPLAYER DUMP` is unchanged.
### Check List (For Author)
- Test
- [x] Unit Test
- [ ] Regression test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [ ] No.
- [x] Yes. `PLAN REPLAYER PLAY '<path>'` now fails to parse; `PLAY` is
no longer a reserved word.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
