morningman opened a new pull request, #66831:
URL: https://github.com/apache/doris/pull/66831
### What
Remove the stale `STORAGE_UNITY_SKIP` entry (and its comment block) for
`compaction/collection_statistics.cpp`, which no longer exists.
### Why — master configure is currently broken
#66052 moved `storage/compaction/collection_statistics.{cpp,h}` to
`storage/index/inverted/similarity/` (rewritten), but left behind the
unity-skip entry that #66789 had added for the old path. The fail-loud
validation introduced by #66789 turns a dangling skip entry into a
configure-time error — which is exactly what it is designed to catch (a skip
list rotting after a file move), so BE configure on current master fails
immediately:
```
CMake Error at CMakeLists.txt:1002 (message):
unity skip entry does not exist (renamed or moved?):
.../be/src/storage/compaction/collection_statistics.cpp
```
The CI pipelines merge each PR into the latest master before building, so
**every PR pipeline that picked up master after #66052 landed is red** (#66826,
#66824, #66819, #66820 were the first hits — same error on multiple independent
agents).
### Why deletion (not a path update) is correct
The old entry existed because the old `collection_statistics_test`
`#include`d the `.cpp` into a second TU (unity batching would then produce a
duplicate definition at link time). The rewritten file at the new location is
not `#include`d by any test (`grep -rn 'collection_statistics.cpp' be/test/` is
empty on master), so the new path needs no skip entry.
### Verification
- Full BE build from a clean tree at master + this change (clang20 / macOS
arm64, unity=ON, PCH=ON): configure passes the skip-list validation and the
build compiles. (The same tree without this change fails configure with the
error above.)
- Timeline note: #66052's last green CI round presumably predates #66789's
validation landing (2026-08-16), which is how the dangling entry slipped
through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
