morningman opened a new pull request, #6:
URL: https://github.com/apache/doris-skills/pull/6
## What
Adds `skills/doris-repo-review`, a contributor-side skill that reviews an
`apache/doris` Pull
Request against a **local source clone**, running the same flow as that
repository's CI Code
Review Runner (`.github/workflows/code-review-runner.yml`).
| Path | Purpose |
|---|---|
| `SKILL.md` | The 12-step workflow: alignment → context → required reading
→ risk scan → subagents → merge → convergence → sweep → documents → report |
| `scripts/align-to-pr.sh` | Resolve the PR, diagnose branch/commit drift,
detach the current worktree onto the PR head |
| `scripts/prepare-review-context.sh` | Authoritative three-dot diff,
new-side changed line ranges, required `AGENTS.md` guides, existing inline
threads, ledger skeleton |
| `scripts/verify-anchors.py` | Prove every `path:line` anchor resolves and
both documents expose the same finding IDs |
| `references/prompts.md` | Subagent prompt templates, carried over from the
CI wording |
| `references/doc-templates.md` | Templates for the two review documents,
anchor format, verdict rule |
## How it maps to CI
Same required reading, same main-agent risk scan before any subagent is
spawned, same 1-3
full-review subagents plus risk-focused subagents, same shared ledger, same
cap of 3 convergence
rounds, same per-checkpoint conclusions. Two deliberate differences:
- CI posts GitHub inline comments; a local run cannot, so the output is an
English and a Chinese
document under `review-docs/`. Anchors are therefore mandatory — every
finding carries
`path:line` (new-side) plus a verbatim snippet, checked by
`verify-anchors.py`.
- CI writes one ledger file with sections; locally, concurrent subagents
would collide on patch,
so it becomes one file per owner under `ledger/`. Same semantics.
## Safety
Read-only: no build, no tests, no changes to repository source, nothing
posted to GitHub. The
worktree switch is refused outright when tracked files are modified or an
operation is in
progress — the script never commits, stashes, resets or deletes on the
user's behalf, and the
switch itself is `git checkout --detach`, so no branch ref moves.
## Notes for reviewers
- Unlike the existing skills, this one operates on a Doris **source**
checkout rather than a
running cluster. The README's Skills table and a one-line note now say so;
happy to reshape that
framing if the repository would rather keep a strict cluster-side scope.
- The README layout tree is also brought back in sync with `skills/` — it
was still listing only
the original two skills. Easy to drop from this PR if you would prefer it
separate.
- No `verify/` changes: the suite covers the DDL and CLI claims of
`doris-best-practices` /
`doris-architecture-advisor`, and this skill makes no such claims (same as
`doris-debug` and
`doris-profile-reader`).
- Smoke-tested `align-to-pr.sh <PR> --check` against a real `apache/doris`
clone: PR resolution,
branch check, commit check, fetch-source detection and the restore hint
all report correctly,
and check mode changes nothing.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
