github-actions[bot] commented on code in PR #62649:
URL: https://github.com/apache/doris/pull/62649#discussion_r3796057380
##########
be/src/storage/segment/encoding_info.cpp:
##########
@@ -386,8 +386,8 @@ EncodingInfoResolver::EncodingInfoResolver() {
_set_v3_default<FieldType::OLAP_FIELD_TYPE_LARGEINT, PLAIN_ENCODING>();
_set_v3_default<FieldType::OLAP_FIELD_TYPE_UNSIGNED_BIGINT, BIT_SHUFFLE>();
_set_v3_default<FieldType::OLAP_FIELD_TYPE_UNSIGNED_INT, BIT_SHUFFLE>();
- _set_v3_default<FieldType::OLAP_FIELD_TYPE_FLOAT, BIT_SHUFFLE>();
- _set_v3_default<FieldType::OLAP_FIELD_TYPE_DOUBLE, BIT_SHUFFLE>();
+ _set_v3_default<FieldType::OLAP_FIELD_TYPE_FLOAT, PLAIN_ENCODING>();
Review Comment:
Please regenerate the affected V3 SegmentFlusher goldens with this default
change. Normal `SegmentFlusherFormatTest` execution byte-compares generated
segments with the checked-in files, and this PR updates none of them. Besides
the two `all_scalar_values_v3_*` cases, four `complex_v3_*` cases materialize
`nested.y:3.5` as a DOUBLE subcolumn, so six case directories fail and ten
`.dat` blobs differ. Those fixtures were generated while V3 FLOAT/DOUBLE used
BIT_SHUFFLE; this line changes their stored `ColumnMetaPB.encoding` and page
bytes to PLAIN. Please regenerate all six affected case directories and run the
full `SegmentFlusherFormatTest` suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
