github-actions[bot] commented on code in PR #66843:
URL: https://github.com/apache/doris/pull/66843#discussion_r3796174274
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/DayMicrosecondAdd.java:
##########
@@ -41,10 +41,10 @@ public class DayMicrosecondAdd extends ScalarFunction
implements BinaryExpression, ExplicitlyCastableSignature,
ComputeSignatureForDateArithmetic, PropagateNullable,
DateAddSubMonotonic {
public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
- FunctionSignature.ret(DateTimeV2Type.MAX)
- .args(DateTimeV2Type.MAX, VarcharType.SYSTEM_DEFAULT),
- FunctionSignature.ret(TimeStampTzType.MAX)
- .args(TimeStampTzType.MAX, VarcharType.SYSTEM_DEFAULT)
+ FunctionSignature.ret(DateTimeV2Type.WILDCARD)
Review Comment:
[P1] Cover the remaining scale-promoting TIMESTAMPTZ siblings
These wildcard signatures fix the six day/hour/minute classes, but
`SecondMicrosecondAdd/Sub`, `MicroSecondsAdd/Sub`, and `MilliSecondsAdd/Sub`
still declare the ordered concrete pair `DATETIMEV2(6)` then `TIMESTAMPTZ(6)`.
For example, a typed scale-3 column still binds as:
```text
Project(second_microsecond_add(
CAST(ts3#1: TIMESTAMPTZ(3) AS DATETIMEV2(6)), '0.000001'
) : DATETIMEV2(6))
```
Neither concrete signature is identical for scales 0-5, both tie in the
implicit round, and search keeps the first DATETIMEV2 candidate before those
classes inspect the selected family. All six paths are reachable and already
have dedicated TIMESTAMPTZ FE/BE overloads, so they still return the wrong
family and use session-local DATETIMEV2 semantics. This is distinct from the
earlier thread, which covered only the six changed classes. Please use family
wildcard signatures for these siblings too and extend the typed scale-0/3/6
type/runtime matrix to cover them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
