airborne12 opened a new pull request, #66874:
URL: https://github.com/apache/doris/pull/66874
### What problem does this PR solve?
Issue Number: None
Related PR: #66052
Problem Summary:
`SEARCH ... PREFIX` values retain their trailing DSL `*` marker in FE. SNII
classifies a custom keyword analyzer as analyzed, but that analyzer preserves
the marker as a literal byte. Consequently, a predicate such as `fail*` sent
`fail*` to the phrase-prefix reader instead of the indexed prefix `fail` and
returned no rows, while V3 matched the expected documents.
This PR strips exactly the trailing DSL marker before SNII phrase-prefix
analysis. Non-analyzed keyword fields continue to use `WILDCARD_QUERY` with the
marker intact, ordinary WILDCARD clauses are unchanged, and the V3 path is
unchanged. The change is query-only: it does not alter index writes or the
on-disk format, so existing SNII indexes are fixed after upgrade without
rebuilding.
TDD evidence:
- RED: a real custom keyword tokenizer/analyzer preserved `fail*`;
`FunctionSearch::build_leaf_query` sent `fail*` and produced an empty bitmap
instead of `{0, 2}`.
- GREEN: the same path sends `fail`, retains `MATCH_PHRASE_PREFIX_QUERY`,
and produces `{0, 2}`.
- All 98 `FunctionSearchTest` cases pass.
- `./build.sh --be -j 192` passes with ASAN.
- `build-support/check-format.sh` passes.
### Release note
Fix SEARCH PREFIX queries on SNII indexes that use a custom keyword analyzer.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. SNII phrase-prefix queries no longer pass the PREFIX DSL `*`
syntax marker to analyzed readers.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
