morrySnow commented on code in PR #16125:
URL: https://github.com/apache/doris/pull/16125#discussion_r1089623365
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AggregateStrategies.java:
##########
@@ -416,7 +416,9 @@ private List<PhysicalHashAggregate<Plan>>
twoPhaseAggregateWithCountDistinctMult
.build();
PhysicalHashAggregate<Plan> gatherLocalAgg = new
PhysicalHashAggregate<>(
localAggGroupBy, localOutput,
Optional.of(partitionExpressions),
- new AggregateParam(AggPhase.LOCAL, AggMode.INPUT_TO_BUFFER),
+ new AggregateParam(AggPhase.LOCAL,
+ logicalAgg.getGroupByExpressions().isEmpty() ?
AggMode.INPUT_TO_RESULT
+ : AggMode.INPUT_TO_BUFFER),
Review Comment:
or, it must be three stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
