goutamadwant opened a new pull request, #66930:
URL: https://github.com/apache/doris/pull/66930
### What problem does this PR solve?
Issue Number: close #66571
Related PR: None
Problem Summary:
When database-level binlog is disabled and only the original table has
binlog enabled, a `swap=false` `REPLACE TABLE` can skip its binlog after an FE
restart or failover. The original table is removed before a cold
`BinlogConfigCache` can resolve its configuration.
This change captures the original table's `BinlogConfig` before replacement
and persists it in `ReplaceTableOperationLog`. Live emission, follower replay,
table-level GC settings, and image recovery use that snapshot. Image recovery
pre-processes one existing database region at a time before filtering table
dummies, while missing databases and disabled-binlog images remain streaming.
Legacy logs without a snapshot retain their previous behavior.
### Release note
Fix missing `REPLACE TABLE` binlogs when only table-level binlog is enabled
and the FE binlog config cache is cold.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. `REPLACE TABLE` now preserves the original table's binlog
configuration for emission and recovery.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg.
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
