JNSimba commented on code in PR #66950:
URL: https://github.com/apache/doris/pull/66950#discussion_r3818318388
##########
fe/fe-core/src/main/java/org/apache/doris/job/util/StreamingJobUtils.java:
##########
@@ -417,6 +418,13 @@ public static LinkedHashMap<String, CreateTableCommand>
generateCreateTableCmds(
// Validate and apply exclude_columns for this table
Set<String> excludeColumns = parseExcludeColumns(properties,
table);
+ if (targetDatabase.isTableExist(targetTableName)) {
+ validateExcludedPrimaryKeys(excludeColumns, table,
primaryKeys);
+ createtblCmds.put(table, Optional.empty());
+ continue;
+ }
Review Comment:
Fixed. For precreated targets, non-empty exclude_columns is now validated
against raw upstream JDBC column names before returning, then the existing
primary-key validation is applied. This path does not invoke JDBC-to-Doris type
mapping. Added a regression assertion for an unknown excluded column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
