csun5285 commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3826705456


##########
be/src/storage/segment/vertical_segment_writer.cpp:
##########
@@ -151,8 +151,7 @@ Status 
VerticalSegmentWriter::_create_column_writer(uint32_t cid, const TabletCo
     opts.need_zone_map = column.is_key() || tablet_schema->keys_type() != 
KeysType::AGG_KEYS;
     opts.need_bloom_filter = column.is_bf_column();
     if (opts.need_bloom_filter) {
-        opts.bf_options.fpp =
-                tablet_schema->has_bf_fpp() ? 
tablet_schema->bloom_filter_fpp() : 0.05;
+        opts.bf_options.fpp = tablet_schema->get_bloom_filter_fpp(column);

Review Comment:
   之前的tablet_schema->has_bf_fpp() ? tablet_schema->bloom_filter_fpp() 没用就删了吧



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to