TsukiokaKogane commented on code in PR #66338:
URL: https://github.com/apache/doris/pull/66338#discussion_r3827009598
##########
be/src/storage/merger.cpp:
##########
@@ -77,6 +77,12 @@ Status Merger::vmerge_rowsets(BaseTabletSPtr tablet,
ReaderType reader_type,
reader_params.tablet = tablet;
reader_params.reader_type = reader_type;
reader_params.read_row_binlog = tablet->is_row_binlog_tablet();
+ if (reader_params.read_row_binlog) {
+ // Row-binlog horizontal (non-vertical) compaction must produce a
globally
+ // (key, TSO)-ordered output.
+ reader_params.read_orderby_key = true;
Review Comment:
not necessary
##########
be/src/storage/rowset/beta_rowset_writer.cpp:
##########
@@ -1074,6 +1074,17 @@ Status
BaseBetaRowsetWriter::_build_rowset_meta(RowsetMeta* rowset_meta, bool ch
!is_segment_overlapping(segments_encoded_key_bounds) &&
_context.tablet_schema->cluster_key_uids().empty()) {
rowset_meta->set_segments_overlap(NONOVERLAPPING);
+ } else if (!segments_encoded_key_bounds.empty() &&
+ is_segment_overlapping(segments_encoded_key_bounds) &&
Review Comment:
could ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
