github-actions[bot] commented on code in PR #66717:
URL: https://github.com/apache/doris/pull/66717#discussion_r3827103666
##########
be/src/information_schema/schema_catalog_meta_cache_stats_scanner.cpp:
##########
@@ -79,20 +96,28 @@ Status
SchemaCatalogMetaCacheStatsScanner::_get_meta_cache_from_fe() {
request.__set_schema_table_name(TSchemaTableName::CATALOG_META_CACHE_STATS);
request.__set_schema_table_params(schema_table_request_params);
- TFetchSchemaTableDataResult result;
-
RETURN_IF_ERROR(ThriftRpcHelper::rpc<FrontendServiceClient>(
_fe_addr.hostname, _fe_addr.port,
- [&request, &result](FrontendServiceConnection& client) {
- client->fetchSchemaTableData(result, request);
+ [&request, result](FrontendServiceConnection& client) {
+ client->fetchSchemaTableData(*result, request);
},
_rpc_timeout));
+ return Status::create(result->status);
+}
- Status status(Status::create(result.status));
+Status SchemaCatalogMetaCacheStatsScanner::_get_meta_cache_from_fe() {
+ TFetchSchemaTableDataResult result;
+ Status status = _fetch_from_fe(_s_tbls_columns.size(), &result);
if (!status.ok()) {
Review Comment:
[P2] Restrict the legacy fallback to unsupported columns
This retries the 23-column projection for every non-OK result, including
transport errors and unrelated failures from a current FE. If that immediate
retry succeeds, the scanner treats the server as legacy and returns all ten
supported weight columns as NULL, masking the original failure and silently
hiding quota/rejection telemetry. Please select the legacy request from an
explicit FE capability/version (or a positively identified unsupported-column
status) and preserve unrelated first-request errors; add a current-FE
transient-error regression alongside the old-FE fallback case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
