github-actions[bot] commented on code in PR #67043:
URL: https://github.com/apache/doris/pull/67043#discussion_r3836102707
##########
be/src/storage/iterator/olap_data_convertor.cpp:
##########
@@ -549,7 +549,7 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorChar::convert_to_olap() {
// If column_string is not padded to full, we should do padding here.
if (should_padding(column_string, _length)) {
- _column = clone_and_padding(column_string, _length);
+ _column = clone_and_padding(column_string, _length, _nullmap);
Review Comment:
Padding eligibility also needs to ignore NULL payloads. For `CHAR(4)`, a
live `"a"` (1 byte) plus a NULL row with a 7-byte nested payload has
`chars.size() == 2 * 4`, so `should_padding()` returns false and this new call
never executes. Debug then fails the live-row width `DCHECK`; release forwards
a 1-byte `Slice`, and a 4-byte CHAR short key reaches `CHECK(index_size <=
slice->size)`. Please make the predicate inspect non-NULL rows using the same
unshifted map, and add a production-converter test for this compensating-size
case; existing tests never exercise the new null-map branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
