Jay-ju commented on PR #66999: URL: https://github.com/apache/doris/pull/66999#issuecomment-5384664942
**Re: target branch — why this sits on branch-4.1 and not master** A heads-up on branch choice, since I initially assumed branch-4.1 was simply "a bit ahead" of master. After checking, the whole Lance integration currently lives only on branch-4.1, not master: - Lance was first merged to **master** via #62182, then **reverted from master** by #65303 (and the lance-c thirdparty in #65304 was likewise reverted). - The integration was then re-established on **branch-4.1** starting from #65730, and every Lance PR since (including #66581, #66597, #66608, #66841, and this one) has targeted branch-4.1. So branch-4.1 is intentionally ahead of master for Lance. This PR depends on that branch-4.1-only base (`LanceScanNode` / `LanceSplit` / `lance_reader`), which is why it targets branch-4.1. Question for the maintainers: is Lance planned to be forward-ported to master? If so, I'm happy to prepare master PRs in dependency order for my changes (#66597 -> #66608 -> #66999) once the base integration (#65730 etc.) lands there. Please advise on the preferred branch strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
