EscaperLL opened a new pull request, #67049:
URL: https://github.com/apache/doris/pull/67049
### What problem does this PR solve?
Issue Number: close #67048
Related PR: N/A
Problem Summary: A transaction commit can succeed on BE while its response
times out. Retrying the same load and rowset may provide an empty
PendingRowsetGuard or a guard from another pending set. The duplicate-commit
path unconditionally moved that guard over the initialized guard stored in
TabletTxnInfo, violating the move-assignment invariant and triggering a CHECK.
Preserve the guard associated with the canonical rowset, while still
disarming duplicate guards from the same set without removing the pending
rowset ID.
### Release note
Fix a BE crash when retrying a transaction commit after a timeout.
### Check List (For Author)
- Test: Unit Test
- TxnManagerTest.CommitTxnTwiceWithEmptyPendingRowsetGuard
- TxnManagerTest.CommitTxnTwiceWithDifferentPendingRowsetSet
- Behavior changed: Yes. Duplicate transaction commits preserve the
canonical rowset guard.
- Does this need documentation: No.
### What problem does this PR solve?
Issue Number: #67048
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
A duplicate transaction commit with an empty or different pending
rowset guard now succeeds without replacing the guard associated
with the canonical rowset.
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
