yiguolei commented on code in PR #67005:
URL: https://github.com/apache/doris/pull/67005#discussion_r3841019646
##########
be/src/exec/operator/materialization_opertor.cpp:
##########
@@ -449,16 +449,20 @@ Status
MaterializationSharedState::validate_rpc_results(int node_id) {
void MaterializationSharedState::_update_profile_info(int64_t backend_id,
RuntimeProfile*
response_profile) {
+ DORIS_CHECK(response_profile != nullptr);
if (!backend_profile_info_string.contains(backend_id)) {
backend_profile_info_string.emplace(backend_id,
std::map<std::string,
fmt::memory_buffer> {});
}
auto& info_map = backend_profile_info_string[backend_id];
- auto update_profile_info_key = [&](const std::string& info_key) {
+ auto update_profile_info_key = [&](const std::string& info_key, bool
warn_if_missing = true) {
const auto* info_value = response_profile->get_info_string(info_key);
Review Comment:
这个不应该加参数
我们应该是DCHECK，直接挂掉，防止出错
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
