zhangstar333 commented on PR #66805: URL: https://github.com/apache/doris/pull/66805#issuecomment-5391490602
> > LGTM. This work is, in my opinion, a very useful foundational effort that can help us implement more providers in the future. After this PR, I think there are two remaining things worth doing. > > > > 1. One is the Thrift-related aspect you mentioned earlier. struct TLanceScanParams shape is better, maybe we could use the num 37 as TLanceScanParams, and remove 38,39 in master and branch-41. > > 2. support OSS... provider, These will make the various storage objects clearer to us. > > @FANNG1 I'm not sure if you have time to handle these. If anything comes up, we can discuss it further. > > Sure, I could do the OSS support okk, very thinks @FANNG1 and seems the code have conflicts, u could rebase it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
