924060929 commented on code in PR #65889:
URL: https://github.com/apache/doris/pull/65889#discussion_r3842605149
##########
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##########
@@ -455,10 +457,22 @@ private CacheTable
buildCacheTableForOlapScanNode(OlapScanNode node) {
olapTable.getVersionInBatchForCloudMode(partitionIds);
} catch (RpcException e) {
LOG.warn("Failed to get version in batch for cloud mode,
partitions {}.", partitionIds, e);
+ } catch (RuntimeException e) {
+ // In cloud mode, a partition dropped concurrently with this batch
lookup resolves to
+ // null and surfaces here as an NPE (not RpcException). Swallow it
and let the
+ // null-check below throw the controlled exception instead.
+ LOG.warn("Failed to get version in batch for cloud mode,
partitions {}.", partitionIds, e);
Review Comment:
I don't think you should treat RuntimeException must be a cloud mode
exception. You should change the exception message for common case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
