This is an automated email from the ASF dual-hosted git repository.
hello-stephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 34015879660 [fix](test) use Cloud Table Stream read-state hook (#67079)
34015879660 is described below
commit 340158796608b7bd9185ff59aea27c3b73a2edd3
Author: Gabriel <[email protected]>
AuthorDate: Tue Aug 25 14:28:44 2026 +0800
[fix](test) use Cloud Table Stream read-state hook (#67079)
## What problem does this PR solve?
A Cloud Table Stream test still instantiated
`ResolveCloudTableStreamReadState` after that generic rewrite rule was
removed, causing FE test compilation to fail.
## What is changed?
Invoke `CloudTableStreamReadStateHook.resolve` through the test existing
reflection utility. This keeps the partial-response retry coverage on
the production post-analysis lifecycle that now owns read-state
installation.
## Testing
- `InsertIntoTableCommandTableStreamTest`: 13 tests passed
- FE Checkstyle passed
---
.../commands/insert/InsertIntoTableCommandTableStreamTest.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommandTableStreamTest.java
b/fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommandTableStreamTest.java
index f58d5d497a9..0d989e9e98a 100755
---
a/fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommandTableStreamTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommandTableStreamTest.java
@@ -618,15 +618,17 @@ public class InsertIntoTableCommandTableStreamTest
extends TestWithFeService {
.build();
}).thenAnswer(invocation ->
buildReadStateResponse(invocation.getArgument(0)));
- ResolveCloudTableStreamReadState resolver = new
ResolveCloudTableStreamReadState();
+ // Read-state installation is a post-analysis invariant, so
exercise the hook that
+ // owns this lifecycle instead of the removed generic rewrite
rule.
org.apache.doris.nereids.exceptions.AnalysisException
exception = Assertions.assertThrows(
org.apache.doris.nereids.exceptions.AnalysisException.class,
- () -> resolver.rewriteRoot(analyzedPlan, null));
+ () -> Deencapsulation.invoke(
+ CloudTableStreamReadStateHook.class,
"resolve", analyzedPlan));
Assertions.assertTrue(exception.getMessage()
.contains("did not return all Cloud Table Stream
bindings"));
Assertions.assertTrue(wrappers.stream().noneMatch(OlapTableStreamWrapper::hasCloudReadStates));
- resolver.rewriteRoot(analyzedPlan, null);
+ Deencapsulation.invoke(CloudTableStreamReadStateHook.class,
"resolve", analyzedPlan);
Assertions.assertTrue(wrappers.stream().allMatch(OlapTableStreamWrapper::hasCloudReadStates));
ArgumentCaptor<Cloud.GetTableStreamOffsetRequest>
requestCaptor =
ArgumentCaptor.forClass(Cloud.GetTableStreamOffsetRequest.class);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
