Gabriel39 commented on code in PR #67053:
URL: https://github.com/apache/doris/pull/67053#discussion_r3850343114


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java:
##########
@@ -265,6 +265,9 @@ private void checkStrictModeAndFilterRatio() throws 
Exception {
      */
     public void executeSingleInsert(StmtExecutor executor) throws Exception {
         try {
+            // Nereids insert unregisters its coordinator before returning to 
StmtExecutor, so the
+            // execution owner must exist before any terminal BE snapshot can 
race that teardown.
+            executor.beginAuditStatisticsOwnership();

Review Comment:
   Fixed in d47a0b12d0. Runtime-statistics ownership now requires explicit 
audit intent from callers that guarantee an AuditLogHelper handoff. Direct 
task, insert, TVF, and group-commit helper paths no longer register ownership 
implicitly, and AuditLogHelper guarantees transfer-or-release even when audit 
construction fails. Repeated success and failure coverage verifies both 
ownership and backend-statistics maps return to zero.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to