Copilot commented on code in PR #692:
URL:
https://github.com/apache/doris-flink-connector/pull/692#discussion_r3852243165
##########
flink-doris-connector/flink-doris-connector-base/src/main/java/org/apache/doris/flink/source/reader/DorisFlightValueReader.java:
##########
@@ -297,7 +298,12 @@ public boolean hasNext() {
}
if (!eos.get()) {
eos.set(!arrowReader.loadNextBatch());
- if (!eos.get()) {
+ if (eos.get()) {
+ LOG.info(
+ "Flight SQL scan finished, split: {}, records:
{}",
+ split.splitId(),
+ readRowCount);
+ } else if (!eos.get()) {
Review Comment:
Redundant condition: the `else if (!eos.get())` branch is guaranteed
whenever the preceding `if (eos.get())` is false, so the extra check adds noise
and makes the control flow harder to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
