Mryange opened a new pull request, #67145:
URL: https://github.com/apache/doris/pull/67145
`IColumn::insert_range_from()` and `insert_indices_from()` required callers
to pass the same concrete column type as the destination. A top-level
`ColumnConst` source therefore had to be materialized or handled at each call
site. Missing that handling could make paths such as `MutableBlock::add_rows()`
cast a `ColumnConst` to the destination's concrete type and abort.
Root cause: constant-source handling was outside the common `IColumn`
insertion contract. This change makes the public insertion methods non-virtual
entry points that recognize a top-level `ColumnConst` source and append its
single nested value through `insert_many_from()`. Concrete column
implementations move behind `insert_range_from_impl()` and
`insert_indices_from_impl()`, preserving their existing behavior for ordinary
sources and const destinations. The duplicate handling in `FullSorter` is
removed, while the `SegmentIterator` workaround from #67042 is intentionally
retained.
Unit tests cover range and index insertion for numeric, string, nullable,
and array constants, as well as both `MutableBlock::add_rows()` overloads.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
