github-actions[bot] commented on code in PR #67150:
URL: https://github.com/apache/doris/pull/67150#discussion_r3859598745
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneOlapScanTablet.java:
##########
@@ -106,7 +106,7 @@ private Collection<Long> getSelectedTabletIds(List<Column>
schema, Map<String, P
return index.getTabletIdsInOrder();
}
HashDistributionInfo hashInfo = (HashDistributionInfo) info;
- return new HashDistributionPruner(schema, index.getTabletIdsInOrder(),
+ return new HashDistributionPruner(schema, index,
Review Comment:
**[P1] Migrate the Nereids rewrite test with this API change**
`RewriteRuleSuiteTest.testPruneOlapScanTablet` still stubs
`MaterializedIndex#getTabletIdsInOrder()`, but this HASH path now passes that
mock into `HashDistributionPruner`, which calls `getTablets()`. Mockito
supplies an empty list for that unstubbed collection method, so the fully bound
predicate reaches `tablets.get(bucket)` and throws instead of matching the
asserted 19 tablets. Please populate/stub 300 ordered `Tablet` objects (or use
a real `MaterializedIndex`) in that test and run it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
