github-actions[bot] commented on code in PR #67153:
URL: https://github.com/apache/doris/pull/67153#discussion_r3860332841
##########
fe/fe-core/src/test/java/org/apache/doris/qe/SessionVariablesTest.java:
##########
@@ -195,6 +195,19 @@ public void
testExternalTableBatchModeDefaultsAndFuzzyAttribute() throws Excepti
Assertions.assertTrue(varAttr.fuzzy());
}
+ @Test
+ public void testFileScannerV2StaysEnabledInFuzzyMode() throws Exception {
+ SessionVariable sessionVar = new SessionVariable();
Review Comment:
This only verifies the pristine Java default. Real connections clone
`VariableMgr.defaultSessionVariable` before `initFuzzyModeVariables()`; that
default is mutable via `SET GLOBAL` and persisted/replayed. If it is `false`,
fuzzy initialization now leaves it false and the forwarded option still selects
legacy V1, so fuzzy sessions are not actually guaranteed to stay on V2. Please
exercise an inherited false here and restore an unconditional
`enableFileScannerV2 = true` assignment in `initFuzzyModeVariables()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
