suxiaogang223 opened a new pull request, #67163:
URL: https://github.com/apache/doris/pull/67163

   ### What problem does this PR solve?
   
   Problem Summary:
   
   Doris rejected database properties for every Paimon catalog except HMS and 
for every Iceberg catalog except HMS, even when the upstream catalog 
implementation supports namespace/database properties. In particular, this 
prevented creating databases with properties in Paimon JDBC catalogs.
   
   This change aligns Doris with the upstream catalog capabilities:
   
   - Paimon: allow properties for HMS, JDBC, REST, and DLF catalogs; keep 
rejecting them for filesystem catalogs.
   - Iceberg: allow properties for HMS, JDBC, REST, and Glue catalogs; keep 
rejecting them for Hadoop, DLF, and S3 Tables catalogs.
   - Forward the property map unchanged to supported catalog implementations.
   - Add unit coverage for both supported and unsupported catalog types, and 
extend the JDBC/REST regression cases.
   
   ### Release note
   
   Support creating databases with properties in supported Paimon and Iceberg 
catalogs.
   
   ### Check List (For Author)
   
   - Test
       - [x] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
   Unit tests:
   
   ```shell
   DORIS_GCC_HOME=/usr mvn test -pl fe-common,fe-core -am -Dskip.clean=true 
-Dcheckstyle.skip=true -DfailIfNoTests=false 
-Dtest=org.apache.doris.datasource.paimon.PaimonMetadataOpsTest,org.apache.doris.datasource.iceberg.IcebergMetadataOpTest
   ```
   
   Result: 18 tests passed. The external JDBC/REST regression cases were 
updated but were not executed locally because they require the full external 
service environment.
   
   - Behavior changed:
       - [ ] No.
       - [x] Yes. Database properties are now accepted and forwarded for 
catalog implementations that support them; unsupported implementations continue 
to return the existing not-supported error.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to