AntiTopQuark commented on code in PR #66191:
URL: https://github.com/apache/doris/pull/66191#discussion_r3868745547


##########
fe/fe-core/src/main/java/org/apache/doris/clone/ColocateTableCheckerAndBalancer.java:
##########
@@ -558,6 +567,9 @@ private void matchGroups() {
                                             replicaAlloc, 
System.currentTimeMillis());
                                     // the tablet status will be set again 
when being scheduled
                                     tabletCtx.setTabletHealth(tabletHealth);
+                                    if (rowBinlogHealthResult != null) {
+                                        
rowBinlogHealthResult.applyTo(tabletCtx);

Review Comment:
   Fixed per the "equivalent explicit repair reason" approach: added 
`RowBinlogRepairReason` to distinguish `BACKEND_MISMATCH`, `PATH_MISMATCH`, and 
`REDUNDANT`, and noted in `applyTo()` that `colocateBackendsSet` is only used 
to convey the base tablet's valid BE set. Scheduling logs, Proc, and counters 
now independently display the row-binlog base/companion tablet IDs and expected 
vs. actual BE → `pathHash`, and `TabletHealthProcDir` has been updated to call 
`getRowBinlogHealth()`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to