felixwluo opened a new pull request, #67218:
URL: https://github.com/apache/doris/pull/67218
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Executing `select auto_partition_name('list', '10')` could cause BE to core
dump. The BE implementation of `auto_partition_name` relied on FE-side
validation and did not validate runtime argument count or control arguments
before dispatching. When the partition type was not handled as `list`, the code
fell through to the `range` path and unconditionally accessed the third
argument. For two-argument LIST calls, this could trigger an out-of-bounds
vector access and abort the BE process.
This change fixes the issue at the BE function implementation layer by
validating the argument count and partition type before dispatching, validating
RANGE granularity explicitly, and reading string arguments through
`ColumnString::get_data_at()` instead of manual chars/offsets indexing. It also
disables the default constant-argument handling for this function so the
function can preserve and validate its own constant control arguments. A BE
unit test covers `AUTO_PARTITION_NAME('LIST', '10')` and malformed RANGE
arguments.
### Release note
Fix a BE crash when `auto_partition_name` receives invalid or mis-dispatched
runtime arguments.
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
