gavinchou commented on code in PR #67173:
URL: https://github.com/apache/doris/pull/67173#discussion_r3882547950
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/stream/BaseTableStream.java:
##########
@@ -93,30 +93,61 @@ public static TBinlogScanType toThrift(StreamScanType
streamScanType) {
@SerializedName("sr")
private String staleReason = "N/A";
- protected volatile TableIf baseTable;
-
// for persist
public BaseTableStream() {
super(TableType.STREAM);
}
- public BaseTableStream(long id, String streamName, List<Column>
fullSchema, TableIf baseTable) {
- super(id, streamName, TableType.STREAM, fullSchema);
+ public BaseTableStream(long id, String streamName, TableIf baseTable) {
+ super(id, streamName, TableType.STREAM, null);
Review Comment:
Confirmed this is still unresolved in the merged head `6268e7a5548`.
`BaseTableStream` still passes `null` as `fullSchema`, and the Doris Gson
builder still omits null fields. A stream created by this version is therefore
persisted without the schema snapshot required by pre-change FE readers;
replaying the journal or loading the image on an older FE leaves an empty
schema. Please track a follow-up that preserves a compatibility snapshot or
explicitly gates the metadata format, with new-writer/old-reader coverage for
both journal replay and image loading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
