deardeng opened a new pull request, #67313:
URL: https://github.com/apache/doris/pull/67313
check_disk_resource_limit() cleared _disk_resource_limit_mode before reading
statfs whenever the cache had not filled its configured capacity. The [exit,
enter) hysteresis band relies on that member remembering the previous round, so
the pre-clear short-circuited the exit branch and the mode was left whenever
disk usage fell below the enter threshold instead of the exit one.
The pre-clear came in with online capacity change, to undo the mode that
reset_capacity() force-enables when shrinking. Drop that force as well:
reset_capacity() already evicts down to the new capacity under the cache lock,
and the monitor re-enters the mode within one interval if the disk really is
tight. Keeping it while removing the pre-clear would pin the mode on forever
after a shrink.
Publish _disk_limit_mode_metrics once per round, after the decision, so a
single round no longer reports 0 and then 1.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
