csun5285 commented on code in PR #67341:
URL: https://github.com/apache/doris/pull/67341#discussion_r3893177552
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -477,6 +478,12 @@ Status ColumnReader::next_batch_of_zone_map(size_t* n,
MutableColumnPtr& dst) co
// TODO: this work to get min/max value seems should only do once
ZoneMap zone_map;
RETURN_IF_ERROR(ZoneMap::from_proto(*_segment_zone_map, _data_type,
zone_map));
Review Comment:
当前版本的 segment zone map 是对的，老版本的是不对的
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -477,6 +478,12 @@ Status ColumnReader::next_batch_of_zone_map(size_t* n,
MutableColumnPtr& dst) co
// TODO: this work to get min/max value seems should only do once
ZoneMap zone_map;
RETURN_IF_ERROR(ZoneMap::from_proto(*_segment_zone_map, _data_type,
zone_map));
Review Comment:
当前版本的 segment zone map 是对的，老版本的是可能不对的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
