github-actions[bot] commented on code in PR #67357: URL: https://github.com/apache/doris/pull/67357#discussion_r3900430249
########## thirdparty/arrow-paimon-vars.sh: ########## @@ -58,7 +58,9 @@ PAIMON_BUILD_SCHEMA_VERSION="1" # whole-script fingerprint. Keep these exact markers during the schema transition; # version and complete artifact validation are still mandatory before reuse. ARROW_LEGACY_COMPATIBLE_SEMANTIC_FINGERPRINT="ab79ab0bbfbf93f9860050fb751b20fee9e40d96" -PAIMON_LEGACY_COMPATIBLE_SEMANTIC_FINGERPRINT="cb82e41ba46f534e611cdd52e66b53c227d49bf8" +# Dependency ordering does not change the installed Paimon artifacts, so existing +# complete prebuilts remain compatible with the corrected clean-build graph. +PAIMON_LEGACY_COMPATIBLE_SEMANTIC_FINGERPRINT="9887cf1ec13106da4250f8d7ea931a258879089c" Review Comment: [P1] Keep the immediately previous Paimon marker reusable This rotates the selected-input gate to `9887cf1e...`, but `PAIMON_LEGACY_BUILD_FINGERPRINTS` still contains only `dbb6ca6e...`, so the current matcher rejects a complete prebuilt stamped by the base inputs (`cb82e41b...`). Because this patch only changes dependency ordering, those artifacts remain equivalent as the comment says; nevertheless `build.sh` sends such prefixes to recovery, which fails for install-only build-image prefixes. Please add `cb82e41ba46f534e611cdd52e66b53c227d49bf8` to the legacy list and cover that marker in the lifecycle test. ########## thirdparty/test/adbc-jni-config-test.sh: ########## @@ -0,0 +1,35 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -euo pipefail + +ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." &>/dev/null && pwd)" +EXTERNAL_FE_CONF="${ROOT}/regression-test/pipeline/external/conf/fe.conf" +# shellcheck disable=SC2016 # Match the literal option before fe.conf expands DORIS_HOME. +JNI_LIBRARY_OPTION='-Darrow.adbc.driver.jni.library.path=${DORIS_HOME}/lib' + +# External Regression replaces the packaged FE configuration instead of merging it. +# Keep the JNI override in that replacement so ADBC cannot fall back to the jar binary. +java_opts_assignment="$(grep '^JAVA_OPTS_FOR_JDK_17=' "${EXTERNAL_FE_CONF}" || true)" Review Comment: [P2] Check the runtime-effective JDK option assignment `start_fe.sh` processes every uppercase assignment in order, so a later duplicate `JAVA_OPTS_FOR_JDK_17` line overrides an earlier one. This `grep` concatenates all matching lines and the following substring check passes if any earlier assignment contains the JNI property; a later effective assignment can therefore drop the option while this new regression guard stays green. Please either require exactly one assignment or select/parse the final runtime-effective value before asserting the JNI path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
